change: Implement 5: Save selected images to the caller directory and downscale only behind the resize flag #15
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: projects/product-54354138-1#15
Reference in New Issue
Block a user
Implemented image saving into the caller directory and exact-size downscaling behind --resize.
tools/images.py: added stdlib-only helpers
png_chunks,decode_png,encode_png,ico_wrap,ico_unwrap, plusdecode_image,resample_rows,encode_imageand theDecodedImagedataclass; also fixed a real pixel-stride bug in RGBA upsampling (channel step was used as pixel stride, corrupting 8-bit pixels).tools/example.py: removed the inlined codec (now delegated to tools.images);
--downloadwrites each selected image into the caller-specified directory; each stored file is read back and decoded, so a reported path only names a file that exists and opens as the requested format (format/width/height/bytesreported per item, no path for a failed item);--downloadwithout--output-diris now aninvalid_request(request_field, field=output_dir) instead of a hidden default, and DEFAULT_OUTPUT_DIR is gone;--resizestores exactly the requested width/height (one open dimension keeps the source value), re-encodes in the requested format, never upscales and leaves a fitting image's bytes untouched; a per-item save failure is reported in that item and ends the run withpartial_download(exit 6), includingsaved_pathsin the error details.tests/test_download_resize.py: new focused suite over tmp_path dirs and locally built png/ico fixtures (save paths exist and decode, requested-format check, missing --output-dir invalid_request, failing save => partial_download, exact resize dims for png and ico, no upscaling, byte/dimension preservation without --resize, plus codec round-trip tests).
tests/test_cli.py: updated the aspect-ratio resize expectation to the required exact 100x100 stored size.
Target branch task/1-task is already the current head (
d5bb24f), so the tested revision contains the target.Tests:
Facade commands run from /workspace with .venv/bin on PATH (prepared via prepare_environment tools restore):
python -m compileall tools tests(tools.validate) OK;python -m tools.example examples/input.json(tools.smoke) exit 0 with status dry_run;python -m tools.example --help(acceptance help-command) exit 0;python -c "import tools, tools.example, tools.images"(package_import) OK;pytest(tools.test, the exact facade entrypoint) => 142 passed. New tests: tests/test_download_resize.py (13 tests). No network-dependent live-source check was run (sandbox has no egress); all fixtures are locally built real png/ico payloads.Progress:
Completed issue 7: stdlib PNG/ICO decode/encode/wrap/unwrap plus resample helpers live in tools/images.py; tools/example.py saves selected images into the caller directory, requires --output-dir with --download (invalid_request otherwise), verifies every stored file by decoding it before reporting its path, downscales to exactly the requested width/height in the requested format only when --resize is set (never upscaling, otherwise byte-identical), and reports a per-item save failure with the partial_download status/exit code. New tests in tests/test_download_resize.py cover all of that; tests/test_cli.py resize expectation aligned with the exact-size requirement. Facade validate/smoke/help/import all pass and
pytestreports 142 passed on the revision that already contains target task/1-task.Published by developer-agent through Tool Backend.
Closes #7
Developer-agent completed implementation and CI passed, but updating the PR title/body failed.
Intended title: change: Implement 5: Save selected images to the caller directory and downscale only behind the resize flag
Commit:
810ce59af4CI: CI passed.
Intended body:
Implemented image saving into the caller directory and exact-size downscaling behind --resize.
tools/images.py: added stdlib-only helpers
png_chunks,decode_png,encode_png,ico_wrap,ico_unwrap, plusdecode_image,resample_rows,encode_imageand theDecodedImagedataclass; also fixed a real pixel-stride bug in RGBA upsampling (channel step was used as pixel stride, corrupting 8-bit pixels).tools/example.py: removed the inlined codec (now delegated to tools.images);
--downloadwrites each selected image into the caller-specified directory; each stored file is read back and decoded, so a reported path only names a file that exists and opens as the requested format (format/width/height/bytesreported per item, no path for a failed item);--downloadwithout--output-diris now aninvalid_request(request_field, field=output_dir) instead of a hidden default, and DEFAULT_OUTPUT_DIR is gone;--resizestores exactly the requested width/height (one open dimension keeps the source value), re-encodes in the requested format, never upscales and leaves a fitting image's bytes untouched; a per-item save failure is reported in that item and ends the run withpartial_download(exit 6), includingsaved_pathsin the error details.tests/test_download_resize.py: new focused suite over tmp_path dirs and locally built png/ico fixtures (save paths exist and decode, requested-format check, missing --output-dir invalid_request, failing save => partial_download, exact resize dims for png and ico, no upscaling, byte/dimension preservation without --resize, plus codec round-trip tests).
tests/test_cli.py: updated the aspect-ratio resize expectation to the required exact 100x100 stored size.
Target branch task/1-task is already the current head (
d5bb24f), so the tested revision contains the target.Tests:
Facade commands run from /workspace with .venv/bin on PATH (prepared via prepare_environment tools restore):
python -m compileall tools tests(tools.validate) OK;python -m tools.example examples/input.json(tools.smoke) exit 0 with status dry_run;python -m tools.example --help(acceptance help-command) exit 0;python -c "import tools, tools.example, tools.images"(package_import) OK;pytest(tools.test, the exact facade entrypoint) => 142 passed. New tests: tests/test_download_resize.py (13 tests). No network-dependent live-source check was run (sandbox has no egress); all fixtures are locally built real png/ico payloads.Published by developer-agent through Tool Backend.
Saving into the caller directory and exact-size downscaling behind --resize are implemented in the real code paths, covered by a new focused test module, and verified by the facade entrypoints on this exact head SHA (tools.dependencies.restore/validate/test/smoke and acceptance.help-command all
status=passed; pytest collected 142 items with tests/test_download_resize.py's 13 tests green). No protected facade/control path was modified; only .agent-work/ledger.json, tests and tools changed.Findings:
_verify_savedre-decodes every stored file with the in-repo decoder (tools/images.py decode_image -> decode_png/ico_unwrap), which only supports non-interlaced 8/16-bit PNG and PNG-framed ICO. A byte-for-byte--downloadof a valid PNG with palette bit depth 1/2/4 or Adam7 interlace, or of an ICO whose largest frame is a DIB/BMP frame, will now be deleted and reported as a per-item save failure (status partial_download), whereas the previous revision stored such bytes verbatim. Consider falling back to header-level verification (images.inspect_image) for non-resized saves so unmodified downloads are not rejected by the codec's scope limits.Acceptance evidence for
810ce59af4985898bb84ebdc1fa1099b0ef5c8d1:810ce59the facade test entrypoint (pytest) ran it: collection shows tests/test_download_resize.py with 13 passing tests as part of 142 passed. (tests:1-5; tests/test_download_resize.py:1-160; tests/test_download_resize.py:161-320; CI job 8:315-434)pytest(execution_profile tool/python_pytest@1) and the generated workflow .gitea/workflows/ci.yaml runs it via run_ci_stage 'tools.test' ... 'pytest' on pull_request into task/**. In the job log for head810ce59af4the structured record command_id=tools.test stage=command exit_code=0 expected_exit_code=0 status=passed appears right after the pytest summary '142 passed'; tools.dependencies.restore and tools.validate also recorded status=passed for the same commit. (.agent/project.yaml:1-160; .gitea/workflows/ci.yaml:1-160; CI job 8:315-434)